refactor: convert ghost-loading-indicator to signal input #513
+15
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ghostLoadingIndicator property from a traditional decorator-based @Input with getter/setter to a modern signal-based input. The conversion aligns with Angular's signal-based reactivity model and removes the deprecated approach of using setter logic for side effects.
- Converted
ghostLoadingIndicatorfrom@Input()with getter/setter toinput()signal - Moved side effect logic from the setter into an
effect()block in the constructor - Updated template binding to call
ghostLoadingIndicator()as a signal function - Removed the private
_ghostLoadingIndicatorbacking field
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| projects/ngx-datatable/src/lib/components/datatable.component.ts | Converts ghostLoadingIndicator to signal input, moves side effect logic to effect(), updates signal call, and removes backing field |
| projects/ngx-datatable/src/lib/components/datatable.component.html | Updates template binding to call ghostLoadingIndicator() as a signal function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fh1ch
approved these changes
Nov 16, 2025
Member
fh1ch
left a comment
fh1ch
left a comment
There was a problem hiding this comment.
@spike-rabbit flawless work here, thanks a bunch 🙇
LGTM 👍
fh1ch
force-pushed
the
refactor/ghost-loading-indicator
branch
from
d407473 to
a6cfaf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
ghostLoadingIndicatoris a decorator input.What is the new behavior?
ghostLoadingIndicatoris a signal.Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
Using effects to handle side effects is supposed to be a temporary solution. We must convert most fields to signals, before we can use computed instead.